Fix pam and config file handling - #163
Conversation
| install -m 644 data/10-initial-setup.conf $(DESTDIR)/etc/initial-setup/conf.d/10-initial-setup.conf | ||
| install -d $(DESTDIR)/etc/pam.d/ | ||
| install -m 644 pam/initial-setup $(DESTDIR)/etc/pam.d/initial-setup | ||
|
|
There was a problem hiding this comment.
This is already being installed in SPEC:
initial-setup/initial-setup.spec
Line 150 in bef4bb1
I'd prefer having this here in the Makefile, but there is no reason to have it twice.
Looks like this was not done correctly during the recent build system migration, lets fix that.
6cce35b to
6d51463
Compare
vojtechtrefny
left a comment
vojtechtrefny
left a comment
There was a problem hiding this comment.
Looks good to me.
The ELN build fails because python3-wheel is not available. I think wheelis no longer needed since #159 so it might be possible do remove the dependency from pyproject.toml now.
Only pull in the Glade build dependency where we can actually expect it to be available,
Looks like this is no longer needed for a successful build and it breaking ELN, so let's drop it.
6d51463 to
f7e5bf9
Compare
|
Dropped |
|
One more partially related thing: Copr builds on PRs are enabled only for fedora-eln: Lines 19 to 23 in bef4bb1 It would be nice to enable these for rawhide and other versions as well so we can see the changes actually work. This is also why the tests never finish -- they are waiting for the rawhide RPMs, but there are none :-) |
2 participants
Looks like this was not done correctly during the recent build system migration, lets fix that.
Also fix Glade dep on ELN.